Repository navigation
permission: prefer --permission over audit mode - #67036
Merged
nodejs-github-bot merged 2 commits intoNov 11, 2026
Merged
Conversation
When both --permission and --permission-audit are set, run in enforce mode as documented, instead of only reporting denials and keeping the environment variables. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67036 +/- ##
==========================================
- Coverage 92.93% 90.68% -2.26%
==========================================
Files 428 797 +369
Lines 195236 278793 +83557
Branches 30176 53609 +23433
==========================================
+ Hits 181442 252810 +71368
- Misses 13467 16347 +2880
- Partials 327 9636 +9309
🚀 New features to boost your workflow:
|
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Member
Author
|
PTAL @nodejs/security-wg |
UlisesGascon
approved these changes
Nov 9, 2026
RafaelGSS
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
RafaelGSS
added
the
commit-queue
Collaborator
|
Landed in e8c1160 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2026
When both --permission and --permission-audit are set, run in enforce mode as documented, instead of only reporting denials and keeping the environment variables. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #67036 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permission: prefer --permission over audit mode