[nodejs-github-bot]

This is an automated update of inspector_protocol to c0045057ce801744c5e88596a2f1bab1802e.

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg

[aduh95]

../../src/inspector_agent.cc:446:8: error: 'void node::inspector::{anonymous}::ChannelImpl::FallThrough(int, crdtp::span<unsigned char>, crdtp::span<unsigned char>)' marked 'override', but does not override
  446 |   void FallThrough(int call_id,
      |        ^~~~~~~~~~~
../../src/inspector_agent.cc: In member function 'void node::inspector::{anonymous}::ChannelImpl::dispatchProtocolMessage(const v8_inspector::StringView&)':
../../src/inspector_agent.cc:338:59: error: no matching function for call to 'crdtp::Dispatchable::Dispatchable(crdtp::span<unsigned char>)'
  338 |     Dispatchable dispatchable(crdtp::SpanFrom(cbor_buffer));
      |                                                           ^
../../src/inspector_agent.cc:338:59: note: there are 3 candidates
In file included from gen/src/node/inspector/protocol/Forward.h:15,
                 from gen/src/node/inspector/protocol/Protocol.h:18,
                 from gen/src/node/inspector/protocol/DOMStorage.h:10,
                 from ../../src/inspector/dom_storage_agent.h:7,
                 from ../../src/inspector_agent.cc:7:
../../deps/inspector_protocol/crdtp/dispatch.h:124:3: note: candidate 1: 'crdtp::Dispatchable::Dispatchable(crdtp::span<unsigned char>, std::string_view, crdtp::FallthroughCallback)'
  124 |   Dispatchable(span<uint8_t> serialized,
      |   ^~~~~~~~~~~~
../../deps/inspector_protocol/crdtp/dispatch.h:124:3: note: candidate expects 3 arguments, 1 provided
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: candidate 2: 'crdtp::Dispatchable::Dispatchable(const crdtp::Dispatchable&)'
  110 | class CRDTP_EXPORT Dispatchable {
      |                    ^~~~~~~~~~~~
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: no known conversion for argument 1 from 'crdtp::span<unsigned char>' {aka 'std::span<const unsigned char>'} to 'const crdtp::Dispatchable&'
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: candidate 3: 'crdtp::Dispatchable::Dispatchable(crdtp::Dispatchable&&)'
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: no known conversion for argument 1 from 'crdtp::span<unsigned char>' {aka 'std::span<const unsigned char>'} to 'crdtp::Dispatchable&&'
../../src/inspector_agent.cc:345:21: error: 'DispatchResult' is not a member of 'crdtp::UberDispatcher'
  345 |     UberDispatcher::DispatchResult result =
      |                     ^~~~~~~~~~~~~~
../../src/inspector_agent.cc:347:10: error: 'result' was not declared in this scope; did you mean 'ada::result'?
  347 |     if (!result.MethodFound()) {
      |          ^~~~~~
      |          ada::result
In file included from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/url_pattern.h:15,
                 from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/parser-inl.h:8,
                 from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada.h:40,
                 from ../../src/node_url.h:7,
                 from ../../src/inspector_agent.cc:29:
/nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/implementation.h:44:7: note: 'ada::result' declared here
   44 | using result = tl::expected<result_type, ada::errors>;
      |       ^~~~~~
../../src/inspector_agent.cc:352:5: error: 'result' was not declared in this scope; did you mean 'ada::result'?
  352 |     result.Run();
      |     ^~~~~~
      |     ada::result
/nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/implementation.h:44:7: note: 'ada::result' declared here
   44 | using result = tl::expected<result_type, ada::errors>;
      |       ^~~~~~

[legendecas]

Pushed a commit fixing the build failures.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78956/

[codecov]

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.72%. Comparing base (5f602d5) to head (339d2a9).
⚠️ Report is 37 commits behind head on main.

Files with missing lines	Patch %	Lines
src/inspector_agent.cc	62.50%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66653      +/-   ##
==========================================
+ Coverage   90.68%   90.72%   +0.04%     
==========================================
  Files         797      798       +1     
  Lines      279574   280083     +509     
  Branches    53778    53890     +112     
==========================================
+ Hits       253525   254115     +590     
+ Misses      16344    16276      -68     
+ Partials     9705     9692      -13     

Files with missing lines	Coverage Δ
src/inspector_agent.cc	83.39% <62.50%> (+0.25%)	⬆️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[legendecas]

CI is green now.