Conversation
Add reusable AsyncWrap and HandleWrap interfaces and use them for signal_wrap and watchdog typings. This reflects the native inheritance hierarchy and exposes AsyncWrap methods that are already available at runtime. Signed-off-by: leah-1ee <selee3196@gmail.com>
leah-1ee
marked this pull request as ready for review
September 20, 2026 07:15
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some internal binding typings currently flatten methods inherited from native
base classes into each derived class.
For example, the native hierarchy for
SignalWrapis:AsyncWrapgetAsyncId,asyncReset,getAsyncContextFrameForDebuggingOnly,getProviderTypeHandleWrapclose,hasRef,ref,unrefSignalWrapstart,stopThe current
Signaltyping directly declares theHandleWrapmethods, whilethe native inheritance relationship itself is not represented.
This change introduces reusable
AsyncWrapandHandleWrapinterfaces andmodels the same hierarchy in the typings:
The same structure is applied to
TraceSigintWatchdog.This makes binding-specific members easier to distinguish from inherited
members and reduces repeated declarations.
No new runtime APIs are introduced. The
AsyncWrapmethods added to thestatic types of
SignalandTraceSigintWatchdogare already availablethrough the native prototype hierarchy.