https: handle invalid TLS options in proxied requests - #66096
Open
christianaurichzm wants to merge 1 commit into
Open
christianaurichzm wants to merge 1 commit into
christianaurichzm wants to merge 1 commit into
Conversation
tls.connect() can throw while validating TLS options. For proxied HTTPS requests, it is called after the CONNECT response has been received, so the throw happens asynchronously from the original https.request() call and ends the process as an uncaught exception. Catch the error, close the tunnel socket, and propagate it to the request. Signed-off-by: Christian Aurich <christian.aurichzm@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66096 +/- ##
========================================
Coverage 90.27% 90.27%
========================================
Files 789 790 +1
Lines 271473 271600 +127
Branches 51808 51837 +29
========================================
+ Hits 245066 245187 +121
- Misses 16880 16922 +42
+ Partials 9527 9491 -36
🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 18, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid TLS options can cause an uncaught exception when an HTTPS request uses a proxy.
After the proxy responds to CONNECT,
tls.connect()is called from the socket read handler. If TLS option validation throws at that point, the exception is outside the originalhttps.request()call.Catch the error, close the tunnel socket, and propagate it to the request's
'error'handler.The new test covers invalid
minVersion,ciphers, andsecureProtocoloptions.