Skip to content

[v26.x backport] crypto: optimize and benchmark key preparation - #66092

Open
panva wants to merge 1 commit into
nodejs:v26.x-stagingfrom
panva:backport-65892-to-v26.x
Open

[v26.x backport] crypto: optimize and benchmark key preparation#66092
panva wants to merge 1 commit into
nodejs:v26.x-stagingfrom
panva:backport-65892-to-v26.x

Conversation

@panva

@panva panva commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Backports #65892

@panva
crypto: optimize and benchmark key preparation
9b3f7cb 
Optimize asymmetric key preparation with benchmark and regression
coverage for the supported input paths.

Assisted-by: GitHub Copilot, Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#65892
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@panva
panva requested a review from aduh95 September 17, 2026 18:00
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.54%. Comparing base (ca26282) to head (9b3f7cb).
⚠️ Report is 785 commits behind head on v26.x-staging.

Additional details and impacted files 
@@                Coverage Diff                @@
##           v26.x-staging   #66092      +/-   ##
=================================================
+ Coverage          90.24%   90.54%   +0.30%     
=================================================
  Files                729      774      +45     
  Lines             242760   267938   +25178     
  Branches           46044    51087    +5043     
=================================================
+ Hits              219073   242614   +23541     
- Misses             15133    16214    +1081     
- Partials            8554     9110     +556
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 98.27% <100.00%> (+0.91%) ⬆️

... and 338 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77604/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva @nodejs-github-bot @aduh95