Conversation
Adapt deleted Context accesses and surrounding broker APIs to V8 13.6. Original commit message: [compiler] Stop collecting array and object prototypes We can check in O(1) whether an object is either Object.prototype or Array.prototype by directly comparing it with the objects, so there's no need to collect them. Change-Id: Iadedf8b05cae3d67191fb4836c186620dc009118 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6487694 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#99894} Refs: v8/v8@8901c79 Refs: nodejs#66053 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Use the V8 13.6 ReadOnlyRoots API and add the missing bimodal MapRef::is_extensible accessor. Adapt surrounding broker APIs and the removed descriptor load to the v24 implementation. Original commit message: [compiler] Thread-safe IsArrayOrObjectPrototype Bug: 467311868 Change-Id: I574aa62d859030545e6a52d693a61e570381e557 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7460949 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#104707} Refs: v8/v8@c355350 Refs: nodejs#66053 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
inoway46
marked this pull request as ready for review
September 17, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66053
Backport two V8 fixes:
Adapt to V8 13.6 APIs, add
MapRef::is_extensible(), and incrementv8_embedder_stringper backport.The reproduction hits OOM on v24.21.0 but completes with these V8 fixes. Refs: