Skip to content

build,src: gate jspi flag on V8_ENABLE_WEBASSEMBLY #66082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkubaj wants to merge 1 commit into
base: v24.x-staging
Choose a base branch
from
+8 −0
Open

build,src: gate jspi flag on V8_ENABLE_WEBASSEMBLY #66082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@
# Disable v8 hugepage by default.
'v8_enable_hugepage%': 0,

# Disabled by configure --v8-lite-mode.
'v8_enable_webassembly%': 1,

# This is more of a V8 dev setting
# https://github.com/nodejs/node/pull/22920/files#r222779926
'v8_enable_fast_mksnapshot': 0,
Expand Down Expand Up @@ -509,6 +512,9 @@
['v8_enable_v8_checks == 1', {
'defines': ['V8_ENABLE_CHECKS'],
}],
['v8_enable_webassembly == 1', {
'defines': ['V8_ENABLE_WEBASSEMBLY'],
}],
['v8_enable_pointer_compression == 1', {
'defines': ['V8_COMPRESS_POINTERS'],
}],
Expand Down
2 changes: 2 additions & 0 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,8 +786,10 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,
v8_args.emplace_back("--js-source-phase-imports");
}

#if V8_ENABLE_WEBASSEMBLY
// WebAssembly JS Promise Integration
v8_args.emplace_back("--experimental-wasm-jspi");
#endif // V8_ENABLE_WEBASSEMBLY

#ifdef __POSIX__
// Block SIGPROF signals when sleeping in epoll_wait/kevent/etc. Avoids the
Expand Down
Loading