test_runner: remove failure attribute from JUnit reporter - #66072
Open
AlexCannonball wants to merge 1 commit into
Open
AlexCannonball wants to merge 1 commit into
AlexCannonball wants to merge 1 commit into
Conversation
This commit aligns the Node.js test runner's JUnit XML output with the official JUnit specification by removing the non-standard failure attribute from elements. Signed-off-by: Aliaksandr <42497203+AlexCannonball@users.noreply.github.com> Co-authored-by: devholic22 <hyunjoon.tech@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66072 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 789 789
Lines 271482 271481 -1
Branches 51820 51816 -4
=======================================
+ Hits 245030 245033 +3
+ Misses 16926 16925 -1
+ Partials 9526 9523 -3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request is a continuation of the abandoned #59685 by @devholic22, addressing the issue where the JUnit reporter incorrectly embedded the failure message as an attribute on
<testcase>elements, which violates the official JUnit specification.Original authorship has been preserved via the
Co-authored-bytrailer in the commit, based on the original changes from @devholic22's patch: https://github.com/devholic22/node/commit/7cca5c1e7beca16341daa3a4fc9d6275d04b3ba2.patchLinks
Fixes: #59593 (a part related to the XML
testcase:failureattribute value)Supersedes: #59685