tools: patch python3 wrapper from depot_tools - #66070
Draft
richardlau wants to merge 1 commit into
Draft
richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
Patch the `python3` from depot_tools used to build/test V8 to work with Python from the system on x64 instead of the hermetic Python from Google. Signed-off-by: Richard Lau <richard.lau@ibm.com>
Collaborator
Collaborator
Member
Author
|
The CI's have passed but then we've hit a secondary issue with depot_tools on Ubuntu 24.04 which is causing me to try a different approach (checking out the version of depot_tools referenced in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch the
python3from depot_tools used to build/test V8 to work with Python from the system on x64 instead of the hermetic Python from Google.Refs: nodejs/build#4462