feat: print name of changed file that triggers restart#63781
Open
marcopiraccini wants to merge 1 commit into
Open
feat: print name of changed file that triggers restart#63781marcopiraccini wants to merge 1 commit into
marcopiraccini wants to merge 1 commit into
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
force-pushed
the
watch-print-changed-file
branch
from
406e322 to
053ef2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watch: print name of changed file that triggers restart
When running with
--watch, Node now prints which file changed before the restart message, so users can tell which save actually triggered the rebuild.Now:
Implementation
FilesWatcher#onChangerecords the triggering path and includes it on the debouncedchangedevent astrigger.watch_mode.jsprintsChange detected in <path>between the screen-clear and the existingRestartingline, so it stays visible and keeps the existing output ordering intact.Tests in
test-watch-mode*.mjsare updated to assert the new line.Fixes: #63767