Skip to content

fix: prevent memory leak in Blob.prototype.stream() upon cancel #63772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EduardF1 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: prevent memory leak in Blob.prototype.stream() upon cancel #63772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/internal/blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,9 @@ function createBlobReaderStream(reader) {
pending.reject(reason);
}
this.pendingPulls = [];
// Explicitly clear the reader wakeup callback to sever the GC reference
// between the active C++ handle and the pending JS stream.
reader.setWakeup(undefined);
},
// We set the highWaterMark to 0 because we do not want the stream to
// start reading immediately on creation. We want it to wait until read
Expand Down
Loading