Skip to content

stream: check done before backpressure in stream reader#63699

Open
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:stream-read
Open

stream: check done before backpressure in stream reader#63699
watilde wants to merge 1 commit into
nodejs:mainfrom
watilde:stream-read

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Jun 1, 2026

No description provided.

Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jun 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (39b481b) to head (af45981).
⚠️ Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/compose.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63699      +/-   ##
==========================================
- Coverage   91.96%   90.35%   -1.61%     
==========================================
  Files         379      732     +353     
  Lines      166638   236668   +70030     
  Branches    25497    44580   +19083     
==========================================
+ Hits       153242   213835   +60593     
- Misses      13099    14566    +1467     
- Partials      297     8267    +7970     
Files with missing lines Coverage Δ
lib/internal/streams/compose.js 95.47% <66.66%> (-1.24%) ⬇️

... and 479 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants