Skip to content

doc: remove broken npm supported versions link#63672

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
parkhojeong:fix-npm-supported-versions-link
Jun 7, 2026
Merged

doc: remove broken npm supported versions link#63672
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
parkhojeong:fix-npm-supported-versions-link

Conversation

@parkhojeong
Copy link
Copy Markdown
Contributor

@parkhojeong parkhojeong commented May 31, 2026

Removes a broken npm supported versions link and its related sentence from the release guide.

image

Signed-off-by: Hojeong Park <parkhj062@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 31, 2026
@parkhojeong parkhojeong marked this pull request as ready for review May 31, 2026 04:50
@parkhojeong parkhojeong changed the title doc: fix broken npm engine validation link doc: fix broken link in releases guide May 31, 2026
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old file used to exist in npm v7
https://github.com/npm/cli/blame/release/v7/lib/utils/unsupported.js

The replacement file
https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js

also refers back to
https://github.com/npm/cli/blob/latest/package.json#L252-L254

  "engines": {
    "node": "^20.17.0 || >=22.9.0"
  }

where the engines definition for node has no upwards restrictions.

So I'm not sure that keeping a link to https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js is necessary or relevant.

The old non-working link should however be removed in any case.

Comment thread doc/contributing/releases.md Outdated
Signed-off-by: Hojeong Park <parkhj062@gmail.com>

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@parkhojeong parkhojeong changed the title doc: fix broken link in releases guide doc: remove npm supported versions link Jun 2, 2026
@parkhojeong parkhojeong changed the title doc: remove npm supported versions link doc: remove broken npm supported versions link Jun 2, 2026
@parkhojeong
Copy link
Copy Markdown
Contributor Author

@MikeMcC399
Thanks for the suggestion. Addressed in 2d2e878.
Also updated the PR title and description.

@parkhojeong parkhojeong requested a review from MikeMcC399 June 2, 2026 04:23
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the section Release proposal (being changed in this PR) concerns informing the @nodejs/npm team about an upcoming major release, they should ideally participate in this PR review.

In any case, the rest of the Major releases section will need an overhaul since it does not yet take account of Evolving the Node.js Release Schedule, proposed for Node.js 27.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/63672
✔  Done loading data for nodejs/node/pull/63672
----------------------------------- PR info ------------------------------------
Title      doc: remove broken npm supported versions link (#63672)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     parkhojeong:fix-npm-supported-versions-link -> nodejs:main
Labels     doc
Commits    2
 - doc: update npm supported versions link
 - doc: remove npm supported versions link
Committers 2
 - Hojeong Park <parkhj062@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63672
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63672
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 31 May 2026 04:45:44 GMT
   ✔  Approvals: 3
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/63672#pullrequestreview-4408201133
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/63672#pullrequestreview-4438925869
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63672#pullrequestreview-4444666393
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 63672
From https://github.com/nodejs/node
 * branch                  refs/pull/63672/merge -> FETCH_HEAD
✔  Fetched commits as 2adaeeee9cb7..2d2e87828df0
--------------------------------------------------------------------------------
[main 69953b7ac0] doc: update npm supported versions link
 Author: Hojeong Park <parkhj062@gmail.com>
 Date: Sun May 31 13:11:53 2026 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 3db40e1246] doc: remove npm supported versions link
 Author: hojeong park <parkhj062@gmail.com>
 Date: Tue Jun 2 13:10:43 2026 +0900
 1 file changed, 1 insertion(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:369) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update npm supported versions link

Signed-off-by: Hojeong Park <parkhj062@gmail.com>
PR-URL: #63672
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

[detached HEAD 8aee910335] doc: update npm supported versions link
Author: Hojeong Park <parkhj062@gmail.com>
Date: Sun May 31 13:11:53 2026 +0900
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: remove npm supported versions link

Signed-off-by: Hojeong Park <parkhj062@gmail.com>

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
PR-URL: #63672
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

[detached HEAD 6b3e7811ee] doc: remove npm supported versions link
Author: hojeong park <parkhj062@gmail.com>
Date: Tue Jun 2 13:10:43 2026 +0900
1 file changed, 1 insertion(+), 2 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/27086912762

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 7, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2026
@nodejs-github-bot nodejs-github-bot merged commit 45f6b83 into nodejs:main Jun 7, 2026
31 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 45f6b83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants