fs: fix unhandled busy errors in RmSync#62611
Open
louiellan wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
nodejs-github-bot
added
c++
Author
|
As for the test validating this fix, I don't know if I should, since i searched all throughout the codebase, I didn't see any tests testing the retries with the busy errors (e.g., |
Author
|
#35689 might be related here as well |
This fixes the unhandled busy errors in rmSync in the symlink_status call, because the allowed/retryable errors in rmSync could be thrown as early as symlink_status call, but it is only handled in the remove/remove_all calls and can only be retried from there This also fixes overridden errors that might happen in the symlink_status right before the remove/remove_all calls, that might mask the true cause of the error happening in rmSync Refs: nodejs#55555 Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
louiellan
force-pushed
the
fix-rmsync-unhandled-busy-err
branch
from
3cecaa5 to
70c037c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the unhandled busy errors in
RmSyncin thesymlink_statuscall, because the allowed/retryable errors inRmSynccould be thrown as early assymlink_statuscall, but it is only handled in theremove/remove_allcalls and can only be retried from there. Without this, it bypasses thefile_not_foundcheck andrecursivecheck in deleting a directory onENFILE,EMFILE,EBUSY. It can also causeENOTEMPTYerror in the directory in a non-recursiveoptionThis also fixes overridden errors that might happen in the
symlink_statusright before theremove/remove_allcalls, that might mask the previous errorAnd this also fixes a subtle bug in the
retryDelaybecauseSleepin Windows is already inmsunitsRefs: #55555