Skip to content

buffer: remove unreachable overflow check in atob #60161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haramj wants to merge 6 commits into
base: main
Choose a base branch
from
+7 −5
Open

buffer: remove unreachable overflow check in atob #60161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3fae16
buffer: throw RangeError on atob overflow
haramj Oct 8, 2025
a6443cd
buffer: fix lint-js
haramj Oct 8, 2025
8d62e7d
buffer: remove unreachable overflow check in atob
haramj Oct 12, 2025
ac83b9d
buffer: add assert.fail()
haramj Oct 13, 2025
387cb0c
buffer: fix lint error
haramj Oct 13, 2025
ca418cc
buffer: update atob error code comments
haramj Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ const {
inspect: utilInspect,
} = require('internal/util/inspect');

const assert = require('internal/assert');

const {
codes: {
ERR_BUFFER_OUT_OF_BOUNDS,
Expand Down Expand Up @@ -1302,9 +1304,9 @@ function atob(input) {
throw lazyDOMException(
'The string to be decoded is not correctly encoded.',
'InvalidCharacterError');
case -3: // Possible overflow
// TODO(@anonrig): Throw correct error in here.
throw lazyDOMException('The input causes overflow.', 'InvalidCharacterError');
case -3:
assert.fail('Unrecognized simdutf error');
break;
default:
return result;
}
Expand Down
4 changes: 2 additions & 2 deletions src/node_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ static void Btoa(const FunctionCallbackInfo<Value>& args) {
// In case of error, a negative value is returned:
// * -1 indicates a single character remained,
// * -2 indicates an invalid character,
// * -3 indicates a possible overflow (i.e., more than 2 GB output).
// * -3 indicates an unrecognized simdutf error.
static void Atob(const FunctionCallbackInfo<Value>& args) {
CHECK_EQ(args.Length(), 1);
Environment* env = Environment::GetCurrent(args);
Expand Down Expand Up @@ -1386,7 +1386,7 @@ static void Atob(const FunctionCallbackInfo<Value>& args) {
return args.GetReturnValue().Set(value);
}

// Default value is: "possible overflow"
// Default value is: "unrecognized simdutf error"
int32_t error_code = -3;

if (result.error == simdutf::error_code::INVALID_BASE64_CHARACTER) {
Expand Down
Loading