Repository navigation
fix(v8): fetch replace_with crates from crates.io - #1245
Open
joyeecheung wants to merge 1 commit into
Open
joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
This is a stop-gap fix to keep the canary green. To keep the data in sync we need to genereate the replacement crates from chromium's data. For now this just fetch the crates from crates.io and fail if patches are detected. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 69 69
Lines 14105 14105
=======================================
Hits 9384 9384
Misses 4721 4721 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
legendecas
reviewed
Nov 11, 2026
| ctx.temporalCAPIDirectory = dir; | ||
| } | ||
| // Fetch replace_with placeholders from crates.io. | ||
| // This is a stop-gap fix that only works as long as the |
Member
There was a problem hiding this comment.
Seems like an incomplete sentence.
| } catch { | ||
| continue; | ||
| } | ||
| throw new Error(`Detected Chromium patches ${name} in ${chromiumPatches}/${dir}, ` + |
Member
There was a problem hiding this comment.
https://chromium.googlesource.com/chromium/src/third_party/rust/+/refs/heads/main/chromium_crates_io/patches/ are applied when chromium rolls the crates so node-core-utils already carries these patches.
I think this should check patches like https://chromium.googlesource.com/chromium/src/third_party/rust/+/refs/heads/main/icu4x_data/patches/?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stop-gap fix to keep the canary green. To keep the data in sync we need to genereate the replacement crates from chromium's data. For now this just fetch the crates from crates.io and fail if patches are detected.
See nodejs/node-v8#317 (comment)