fix(cli): accept URL value for --git-ref option#767
Open
Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Open
fix(cli): accept URL value for --git-ref option#767Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 604ec8e. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a CLI argument parsing issue where the
--git-refoption was incorrectly defined as a flag instead of accepting a value.The option is intended to take a URL (as indicated by its description), but its previous definition caused the CLI to throw an error when a value was passed. This change updates the option to correctly accept a value.
Validation
Before:
Running the CLI with a value for
--git-reffails because the option is incorrectly parsed as a boolean flag instead of accepting a value.After:
The
--git-refoption is now correctly parsed as a value option, allowing a URL to be passed without causing argument parsing errors.Related Issues
N/A
Check List
node --run testand all tests passed.node --run format&node --run lint.