Skip to content

fix(search): guard renderLabel against hits without a description - #1251

Open
btea wants to merge 2 commits into
nodejs:mainfrom
btea:fix/search-hit-without-description
Open

btea wants to merge 2 commits into
nodejs:mainfrom
btea:fix/search-hit-without-description

Conversation

@btea

@btea btea commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

When I type ne in the search box, the terminal displays an error message, causing the input box pop-up to become unclosable.

Validation

QQ20261107-234427

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner November 7, 2026 15:37
@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Nov 11, 2026 2:37am UTC

Request Review

@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (07858b1) to head (196d78d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1251   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         291      291           
  Lines       29214    29214           
  Branches     2969     2969           
=======================================
  Hits        27515    27515           
  Misses       1677     1677           
  Partials       22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 20.5% faster (730.00 ms → 580.00 ms)
  • Peak memory: 2.3% lower (289.92 MB → 283.31 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 37.2% slower (5.75 s → 7.89 s)
  • Peak memory: 3.8% lower (944.75 MB → 908.50 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 13.5% faster (16.48 s → 14.25 s)
  • Peak memory: 2.5% higher (1.40 GB → 1.44 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 9.7% slower (7.66 s → 8.40 s)
  • Peak memory: 3.4% higher (872.91 MB → 902.29 MB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 33.2% slower (5.84 s → 7.78 s)
  • Peak memory: 13.8% lower (935.59 MB → 806.70 MB)

orama-db Generator

Performance estimate (single CI run)

  • Generation time: 10.4% faster (8.47 s → 7.59 s)
  • Peak memory: 7.5% higher (958.95 MB → 1.01 GB)

web Generator

Output size: 62 files changed · net +15.00 B

File size details
File Main PR Change
assets/SearchBox-9n1mnHaB.js 84.55 KB — -84.55 KB (-100.0%)
assets/SearchBox-Czk3zAlA.js — 84.55 KB +84.55 KB
assets/dist-CnIJ8XGP.js 30.37 KB — -30.37 KB (-100.0%)
assets/dist-CcTrCTuq.js — 30.37 KB +30.37 KB
assets/SideBar-DHTYk6TC.js 25.53 KB — -25.53 KB (-100.0%)
assets/SideBar-wI32vWmt.js — 25.53 KB +25.53 KB
assets/client-CqREPnK9.js 25.44 KB — -25.44 KB (-100.0%)
assets/client-DVawiQOh.js — 25.44 KB +25.44 KB
assets/Combination-BqcNYhpf.js 16.07 KB — -16.07 KB (-100.0%)
assets/Combination-ChWYgx4W.js — 16.07 KB +16.07 KB
assets/ThemeToggle-CwTAxrWI.js 13.61 KB — -13.61 KB (-100.0%)
assets/ThemeToggle-B8nk4WY4.js — 13.61 KB +13.61 KB
assets/compat-DkeB9U1h.js 13.53 KB — -13.53 KB (-100.0%)
assets/compat-CmzhHZq4.js — 13.53 KB +13.53 KB
assets/dist-BLH_Rr38.js 10.16 KB — -10.16 KB (-100.0%)
assets/dist-BIMeDbQj.js — 10.16 KB +10.16 KB
assets/Layout-BfF00dNX.js 10.04 KB — -10.04 KB (-100.0%)
assets/Layout-D5P8MRxu.js — 10.04 KB +10.04 KB
assets/Tooltip-CnMYlYFs.js 7.84 KB — -7.84 KB (-100.0%)
assets/Tooltip-FxDCb8Zn.js — 7.84 KB +7.84 KB
assets/dist-CLGhXHiW.js 6.95 KB — -6.95 KB (-100.0%)
assets/dist-BOjI-Awz.js — 6.95 KB +6.95 KB
assets/dist-Bv2VMEdQ.js 3.89 KB — -3.89 KB (-100.0%)
assets/dist-BAmeET4i.js — 3.89 KB +3.89 KB
assets/CodeTabs-wEu7sdiy.js 3.81 KB — -3.81 KB (-100.0%)
assets/CodeTabs-B3_JE_jg.js — 3.81 KB +3.81 KB
assets/CodeBox-YXLF9NRO.js 3.36 KB — -3.36 KB (-100.0%)
assets/CodeBox-CPF69GtO.js — 3.36 KB +3.36 KB
assets/FunctionSignature-D8zqozIh.js 2.20 KB — -2.20 KB (-100.0%)
assets/FunctionSignature-BdSaRVhi.js — 2.20 KB +2.20 KB
assets/Banner-4fGaX6F9.js 2.04 KB — -2.04 KB (-100.0%)
assets/Banner-BLdsuaR8.js — 2.04 KB +2.04 KB
assets/ChangeHistory-D0IPdHvy.js 1.73 KB — -1.73 KB (-100.0%)
assets/ChangeHistory-B_lqcZvI.js — 1.73 KB +1.73 KB
assets/DataTag-CwRk7EUJ.js 834.00 B — -834.00 B (-100.0%)
assets/DataTag-CcZrNmYY.js — 834.00 B +834.00 B
assets/DocumentationIndex-DJHHnKq0.js 833.00 B — -833.00 B (-100.0%)
assets/DocumentationIndex-UFATXJpQ.js — 833.00 B +833.00 B
assets/classnames-B4RBm4Lf.js 745.00 B — -745.00 B (-100.0%)
assets/classnames-WBL8WajM.js — 745.00 B +745.00 B
assets/Badge-BbGRrcF2.js 597.00 B — -597.00 B (-100.0%)
assets/Badge-CGikX-mW.js — 597.00 B +597.00 B
assets/AlertBox-CRH0CiNU.js 581.00 B — -581.00 B (-100.0%)
assets/AlertBox-CiREWF-P.js — 581.00 B +581.00 B
assets/ArrowUpRightIcon-GB8x2WWs.js 579.00 B — -579.00 B (-100.0%)
assets/ArrowUpRightIcon-DEVIiPfe.js — 579.00 B +579.00 B
assets/CodeBracketIcon-CDCxizh2.js 512.00 B — -512.00 B (-100.0%)
assets/CodeBracketIcon-Bl4l9FJZ.js — 512.00 B +512.00 B
assets/dist-sScOyttL.js 477.00 B — -477.00 B (-100.0%)
assets/dist-DStH_a4l.js — 477.00 B +477.00 B
assets/ChevronDownIcon-BmLGedWk.js 468.00 B — -468.00 B (-100.0%)
assets/ChevronDownIcon-CwYeX3zm.js — 468.00 B +468.00 B
assets/renderLabel-BvGZT1I5.js — 462.00 B +462.00 B
assets/renderLabel-CchXvpBp.js 447.00 B — -447.00 B (-100.0%)
assets/jsx-runtime-DGWrY2l7.js 405.00 B — -405.00 B (-100.0%)
assets/jsx-runtime-C-kEh9Aw.js — 405.00 B +405.00 B
assets/Blockquote-_Mfd8Z3h.js 167.00 B — -167.00 B (-100.0%)
assets/Blockquote-BtMrxh3C.js — 167.00 B +167.00 B
assets/useRemoteConfig-BX7tuC1U.js 116.00 B — -116.00 B (-100.0%)
assets/useRemoteConfig-3POkM4bA.js — 116.00 B +116.00 B
assets/withIsland-wjSwvMAn.js 105.00 B — -105.00 B (-100.0%)
assets/withIsland-8aOstimN.js — 105.00 B +105.00 B

Performance estimate (single CI run)

  • Generation time: 2.5% faster (18.27 s → 17.81 s)
  • Peak memory: 3.2% lower (1.50 GB → 1.45 GB)

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 196d78da Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants