Repository navigation
meta: update pnpm from 11.26.0 to 12.16.1 - #1213
github-actions[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 291 291
Lines 28942 28942
Branches 2942 2942
=======================================
Hits 27248 27248
Misses 1672 1672
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
doc-kit/.github/workflows/update-pnpm.yml Line 62 in 0e999db |
No, it is intentionally a draft so that when one of us marks it ready for review, that triggers the CI to run. |
|
This introduces the two-document lockfile that will break Dependabot security alerts, are we okay with that? |
Could you elaborate? |
GitHub cannot parse the two-document lockfile, so https://github.com/nodejs/doc-kit/security/dependabot will become empty, and we will no longer receive Dependabot alerts/updates for vulnerable dependencies. See dependabot/dependabot-core#15904 + https://github.com/orgs/community/discussions/211597 |
I don't think I understand you. I fail to understand you, could you please elaborate? What is this two-document lockfile? |
In https://github.com/nodejs/doc-kit/blob/8f63bd4df1df07595f90603918c9ecb9d3c43ea1/pnpm-lock.yaml there are now two documents (a document is marked by |
Appreciate the explanation. Marking this as a draft and blocking till upstream gets fixed. |
ovflowd
left a comment
There was a problem hiding this comment.
Blocked by upstream. Otherwise Dependabot will partially stop working.
GitHub fixed the lockfile parsing: dependabot/dependabot-core#15904 (comment)
Updates pnpm from 11.26.0 to 12.16.1
cc @nodejs/web-infra
Check this workflow's logs at https://github.com/nodejs/doc-kit/actions/runs/41257079054.