Add davemhammer/obsidian - #285
Conversation
The daily path is built from the unvalidated Normalize the relative path and require the resolved daily path to remain beneath the vault root before reading, creating directories, writing, or opening it.
The Apply the same vault validation used by
The manifest declares only Declare every spawned executable required at runtime and align obsidian/README.md:13 with the manifest. |
Address review: vault path confinement, open_daily vault check, declare runtime deps (xdg-open, find, sort, head), version 1.0.3.
4a612ce to
ef89bd3
Compare
|
@ItsLemmy - fixes applied for blockers 1-3 as required. |
Plugin
davemhammer/obsidianplugin.toml)What it does
Daily note capture and git status/commit/pull/push for a local Obsidian vault; open notes via
obsidian://URIs.Surfaces: widget
status, panelmanager, serviceservice, launcher/ob(entry idob).Panel IPC:
noctalia msg panel-toggle davemhammer/obsidian:managerVersion:
1.0.3· plugin_api:10· license: MIT · author: davemhammerExternal dependencies
obsidian,git,xdg-open,find,sort,head(all declared inplugin.toml)Trust / side effects
Filesystem: reads/writes markdown only under the configured vault (daily/note paths reject
..and absolute paths); scans recent*.mdmtimes (skips.obsidian,.git,.claudian). Capture/open-daily refuse non-vault paths.Processes:
find/sort/head(recent notes);git status|add|commit|pull|push(pull uses--no-rebase --autostash); abort in-progress rebase/merge when requested;xdg-openfor Obsidian URIs.Network: only whatever
git remotedoes on pull/push — no Obsidian Sync / cloud API.Testing
Tested on Noctalia v5 / Niri with a git-backed vault: daily capture, dirty status, commit/pull/push, open daily note.
Screenshots / Videos
thumbnail.webpwas created with the official thumbnail generator (title/tags/accent export, 960×540 WebP). Live UI screenshots can be added on request during review.Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.