Conversation
The error message on an unbalanced bracket (used in a doc unit) depends on the libc: "Unmatched [" with the GNU libc and "brackets ([ ]) not balanced" on macOS. Let's check only for the shared open bracket. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
The regex library on Apple platforms needs `REG_ENHANCED` to support the the shortcuts `\s`, `\S`, `\w` and `\W`. The GNU libc accepts these shortcuts by default. This was seen in `lib/markdown2` which relies on these shortcuts and where 70 tests were failing on macOS, plus it could break the nitunit program. Intro `Regex::enhanced` to pass the flag when the platform defines it, enabled by default. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
On Apple platforms we need to import `endian.h` from `sys/`. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
On macOS, Homebrew installs GMP outside of the default search paths of the C compiler, so `gmp.h` was not found with only `-lgmp`. Using pkg-config should find it reliably on all platforms. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Test Results 67 files 340 suites 12m 51s ⏱️ Results for commit 70ed601. |
BlackMinou
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update three libs to compile and pass tests on macOS, adapting them to quirks of the Apple platforms:
redefines theenhancedflag to support\s,\S,\w, and\W. Thenitunittools relied on these so it would cause issues at testing other code bases.binaryfindsendian.hat a different path.gmpuses pkg-config to set the compilation flags to be more portable.