Repository navigation
[17.0][FIX] ni_period, partner_age, survey_subject: forward-port of the 16.0 P0-4 fixes - #168
Merged
Merged
Conversation
period_start_date is a stored computed field with a default of today. On create, a default counts as a given value, so the compute never runs: records created from code (import, RPC) with only period_start got today as their start date, and an encounter could then fail the end-date check when it was closed. Drop the default. period_start already defaults to now, so a new record in the form still starts today. The regression test is in ni_patient, which has the first concrete model on the mixin. Refs: nirun-life#135
tests/test_res_partner.py was not imported in tests/__init__.py, so it never ran. It is a near copy of test_res_partner_age.py (the same cases, two assertions in a different order), so there is nothing to merge. Refs: nirun-life#135
The button's invisible condition compared active with the string 'False', which never matches a boolean, so the button also showed on archived surveys. Use not active. Refs: nirun-life#135
39 tasks
Closed
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #135 · Forward-port of #166 (16.0) for the modules already merged on 17.0
Summary (TH)
forward-port การแก้บั๊ก P0-4 จาก #166 มาที่ 17.0 เฉพาะ 3 module ที่ merge บน 17.0 แล้ว ได้แก่ ni_period, partner_age และ survey_subject ส่วน ni_patient, ni_observation และ ni_questionnaire จะใส่ตอน rebase stack ที่รอ review อยู่ (#153–#161) PR นี้จึงไม่ไปแตะ stack นั้น
Changes
ni_periodperiod_start_datehas no default any more, so records created from code get the date ofperiod_start, not today (#141 finding 5)partner_agetests/test_res_partner.py: never imported, a near copy oftest_res_partner_age.pysurvey_subjectnot activeinstead of comparing with the string'False'The commits are the 16.0 ones from #166, with the manifest versions and the 17.0 view syntax adjusted.
Decisions to review
ni_periodregression test lives inni_patient(test_ni_encounter_entered_in_error.pyin [16.0][FIX] Pre-existing bugs found during the 19.0 migration scan #166), so it comes to 17.0 with theni_patientstack.How tested
ni_period, partner_age, survey_subject: 0 failed, 0 errors of 11 tests.pre-commitclean on the changed files.