Repository navigation
[17.0][FIX] partner_gender: depend on mail - #165
Merged
Merged
Conversation
The gender field is tracked (tracking=True), which needs mail; without it Odoo warns "unknown parameter 'tracking'" and gender changes are not logged. The onchange tests use Form, which needs web: when partner_gender is installed before web they fail with "onchange() is implemented in module 'web'". CI passed only because of its install order. 18.0 and 19.0 already depend on mail.
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
partner_gender: depends onmailinstead ofbase; version 17.0.1.0.0 → 17.0.1.0.1.Why
genderis defined withtracking=True, which needsmail. Without it Odoo logsField res.partner.gender: unknown parameter 'tracking'and gender changes are not tracked. The onchange tests useForm, which needsweb: whenpartner_genderis installed beforeweb, they fail withonchange() is implemented in module 'web'. CI on #147 passed only because of its install order.Found while re-testing the rebased 17.0 stack (#153, #156, #159). 18.0 and 19.0 already depend on
mail.How tested
-i partner_gender --test-tags /partner_gender: before, 2 errors of 4 tests; after, 0 failed of 4, and notrackingwarning.pre-commitclean.Notes for reviewer
mailinstalled on the next-u partner_gender(every Nirun database already has it throughni_patient).