Repository navigation
fix(mcp): add viem as a direct dependency to resolve mppx's required peer (#118) - #247
Merged
Merged
Conversation
…peer (#118) mppx declares viem as a non-optional peer (>=2.51.0, confirmed via npm view mppx peerDependenciesMeta - unlike hono/elysia/express, viem has no optional:true entry), so a clean npm install leaves it unresolved and nirium-mcp crashes at startup with ERR_MODULE_NOT_FOUND: viem. Supersedes #124 (same diagnosis, credit to maxx-GENIUS), which was opened against an older main and, if merged as-is, would have regressed @stellar/mpp entirely plus downgraded @modelcontextprotocol/sdk and @stellar/stellar-sdk. This PR only adds the one missing dependency line, verified with a clean install and a successful tsc build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #118.
mppxdeclaresviemas a non-optional peer dependency (>=2.51.0- confirmed vianpm view mppx peerDependenciesMeta, wherehono/elysia/expressare markedoptional: trueandviemis not), so a cleannpm installleaves it unresolved andnirium-mcpcrashes at startup withERR_MODULE_NOT_FOUND: viem.Adds
viem(pinned to the current latest,^2.57.16) directly topackages/mcp/package.json, plus a one-line README note explaining why it's there.Replaces #124 (same root-cause diagnosis - credit to @maxx-GENIUS for finding it). That PR was opened against an older
mainand, merged as-is, would have regressed@stellar/mppentirely and downgraded@modelcontextprotocol/sdkand@stellar/stellar-sdk. This PR only adds the one missing line.Verification
npm install --legacy-peer-depsinpackages/mcpresolves cleanly,npm ls viemshows it deduped undermppx.npm run build(tsc) passes with no errors.@stellar/mpp/@stellar/stellar-sdkpeer mismatch this surfaces is pre-existing onmainand already known/handled -mcp-ci.ymlandsdk-test.ymlalready install with--legacy-peer-depsfor exactly this reason, so no new workaround needed here.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com