Repository navigation
fix(sdk): facilitatorApiKey is required on both networks, not just mainnet - #207
Merged
Merged
Conversation
…innet
The runtime check two lines below the JSDoc comment throws on BOTH
networks ("the facilitator rejects unauthenticated servers on testnet
too"), but the comment itself said "Mainnet lo exige; testnet no." -
directly contradicting the code it describes. Same false claim in the
README's quickstart example comment.
Build + test verified clean after the change (comment-only, but
checked anyway): tsc build passes, 56 jest + 126 node:test all pass.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
M0nsxx
approved these changes
Oct 25, 2026
M0nsxx
left a comment
M0nsxx
left a comment
Collaborator
There was a problem hiding this comment.
CI green, same facilitatorApiKey fix on the SDK source side (item 3). Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/sdk/src/index.ts's JSDoc comment onfacilitatorApiKeysaid "Mainnet lo exige; testnet no." - directly contradicting the runtime check a few lines below, which throws on both networks ("the facilitator rejects unauthenticated servers on testnet too").packages/sdk/README.md's quickstart example comment (line 192, "required on mainnet").Test plan
npm run buildpassesnpm testpasses: 56 jest + 126 node:test, 0 failures🤖 Generated with Claude Code