Implement getSettingDefinitions for declarative settings API - #27
Merged
Conversation
Add getSettingDefinitions() to TextToolsSettingTab so settings are searchable in Obsidian's global settings search on 1.13.0+. Keep display() as a fallback for Obsidian < 1.13.0 since minAppVersion is 1.11.0. Update the lockfile to obsidian 1.13.1 for the new API types. Closes #26
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a13c99caa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nilsandrey
force-pushed
the
bug/26-getSettingDefinitions
branch
from
August 16, 2026 00:35
2a13c99 to
5e38579
Compare
…settings for older versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement
getSettingDefinitions()on the settings tab so the plugin's settings appear in Obsidian's global settings search on Obsidian 1.13.0 and later.Related Issues
Type of Change
Checklist
npm run build)npm test)README.mdFeatures table is updated (if a new command was added)CHANGELOG.mdentry is not required here - the pipeline generates it automaticallyScreenshots / Recordings