fix(room): wire doorbell, rights bypass, password alerts, and brute-force cooldown#2
Draft
Copilot wants to merge 3 commits into
Draft
fix(room): wire doorbell, rights bypass, password alerts, and brute-force cooldown#2Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…sion bypass Agent-Logs-Url: https://github.com/momlesstomato/pixel-server/sessions/591bf464-4304-4ec0-9b31-f7618741e4e3 Co-authored-by: momlesstomato <49842504+momlesstomato@users.noreply.github.com>
…nauthorized approvals Agent-Logs-Url: https://github.com/momlesstomato/pixel-server/sessions/591bf464-4304-4ec0-9b31-f7618741e4e3 Co-authored-by: momlesstomato <49842504+momlesstomato@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix doorbell functionality and password error handling
fix(room): wire doorbell, rights bypass, password alerts, and brute-force cooldown
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room entry had several broken paths: rights holders were forced to ring the doorbell, only the owner received doorbell notifications, wrong passwords produced no visible message, and the entry flow had no brute-force protection.
handleLetUserInalso had no authorization guard and skippedleaveCurrentRoom/visit-recording.Access control
CheckAccess— rights holders now bypassAccessLockeddirectly (no doorbell).room.enter.bypasspermission — skips both password check and doorbell entirely (staff override).Doorbell
triggerDoorbell— notifies every entity in the room that is the owner or holds rights, not just the owner. Cleans up the pending entry immediately when no recipient is found instead of parking the visitor indefinitely.handleLetUserIn— added owner/rights authorization guard (unauthorized packets are dropped with aWarnlog). CallsleaveCurrentRoomon the visitor before assigning the new room. Wires visit recording, which was missing from the doorbell approval path.Dispose— cleans uppendingDoorbellentries and password tracking maps for the disconnecting connection, preventing stale state and memory leaks.Password protection
GenericAlertPacket{"Incorrect room password!"}in addition toCantConnectComposer{ErrorCode:6}so the client shows a visible dialog.Counters and cooldown are reset on successful entry or connection dispose.
Original prompt
Created from VS Code.