Skip to content

Add Ok Fv web components and Storybook coverage#2944

Open
fredvisser wants to merge 24 commits intomainfrom
users/fvisser/fv-ok-web-components-only
Open

Add Ok Fv web components and Storybook coverage#2944
fredvisser wants to merge 24 commits intomainfrom
users/fvisser/fv-ok-web-components-only

Conversation

@fredvisser
Copy link
Copy Markdown
Contributor

@fredvisser fredvisser commented Apr 29, 2026

Summary

Add the Ok Fv web component implementations and Storybook coverage for card, chip selector, context help, split button, split button anchor, summary panel, summary panel tile, and toolbar.

What changed

  • add the new Ok Fv web component source, registration, templates, styles, types, and package tests
  • add Storybook API stories, matrix stories, and MDX docs for the new Ok Fv components
  • update the existing Fv accordion-item and Fv search-input Storybook surfaces to match the current grouped docs/story structure and repo conventions
  • add the Fv component-status entries and the beachball change file for @ni/ok-components
  • restore the Fv-local component-review skill bundle and repository best-practices reference under packages/ok-components/src/fv/.github/skills
  • Fv search input: refine the clear button styling and positioning

Notes

  • this PR intentionally covers the web components and Storybook/docs surface only
  • Angular and Blazor wrappers will follow in a separate PR

Validation

  • npm run build:components -w @ni/ok-components
  • npm run build:ts -w @ni-private/storybook

fredvisser and others added 4 commits April 29, 2026 14:04
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Comment thread packages/storybook/src/utilities/storybook.ts
fredvisser and others added 3 commits April 29, 2026 23:09
Co-authored-by: Copilot <copilot@github.com>
@rajsite rajsite requested review from rajsite and removed request for rajsite April 30, 2026 20:12
Comment thread change/@ni-ok-components-fv-web-components.json Outdated
Comment thread packages/storybook/src/ok/fv/card/fv-card.mdx Outdated
Comment thread packages/ok-components/src/fv/split-button-anchor/template.ts Outdated
Comment thread packages/storybook/src/ok/fv/card/fv-card.stories.ts Outdated
Comment thread packages/storybook/src/ok/fv/card/fv-card.stories.ts
@fredvisser fredvisser marked this pull request as ready for review May 8, 2026 16:11
@fredvisser fredvisser requested a review from jattasNI as a code owner May 8, 2026 16:11
Comment thread packages/ok-components/src/fv/context-help/index.ts Outdated
Comment thread packages/ok-components/src/fv/chip-selector/index.ts Outdated
@rajsite rajsite changed the title Add FV OK web components and Storybook coverage Add Fv OK web components and Storybook coverage May 8, 2026
@rajsite rajsite changed the title Add Fv OK web components and Storybook coverage Add Ok Fv web components and Storybook coverage May 8, 2026
Comment thread packages/ok-components/src/fv/card/styles.ts
Comment thread packages/storybook/src/ok/fv/accordion-item/fv-accordion-item.mdx Outdated
Comment thread packages/storybook/src/ok/fv/card/fv-card.mdx Outdated
Comment thread change/@ni-ok-components-956c8d37-d7bb-4229-b7e0-7c514b563e0e.json Outdated
Copy link
Copy Markdown
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent naming

Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
public allowCustomValues = false;

@observable
public filterText = '';
Copy link
Copy Markdown
Member

@rajsite rajsite May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider doing a pass across all the component index.ts files in the PR / in fv components and marking all the internal class members with the jsdoc /** @internal */

Roughly anything not documented in storybook or marked @attr should probably be internal (unless marked private already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants