Add Ok Fv web components and Storybook coverage#2944
Open
fredvisser wants to merge 24 commits intomainfrom
Open
Add Ok Fv web components and Storybook coverage#2944fredvisser wants to merge 24 commits intomainfrom
fredvisser wants to merge 24 commits intomainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
rajsite
reviewed
Apr 29, 2026
Co-authored-by: Copilot <copilot@github.com>
rajsite
reviewed
Apr 30, 2026
rajsite
reviewed
Apr 30, 2026
rajsite
reviewed
Apr 30, 2026
rajsite
reviewed
Apr 30, 2026
rajsite
reviewed
Apr 30, 2026
rajsite
reviewed
Apr 30, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
rajsite
reviewed
May 8, 2026
rajsite
reviewed
May 8, 2026
rajsite
reviewed
May 8, 2026
rajsite
reviewed
May 8, 2026
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
rajsite
reviewed
May 8, 2026
rajsite
reviewed
May 9, 2026
| public allowCustomValues = false; | ||
|
|
||
| @observable | ||
| public filterText = ''; |
Member
There was a problem hiding this comment.
Consider doing a pass across all the component index.ts files in the PR / in fv components and marking all the internal class members with the jsdoc /** @internal */
Roughly anything not documented in storybook or marked @attr should probably be internal (unless marked private already)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Ok Fv web component implementations and Storybook coverage for card, chip selector, context help, split button, split button anchor, summary panel, summary panel tile, and toolbar.
What changed
@ni/ok-componentscomponent-reviewskill bundle and repository best-practices reference underpackages/ok-components/src/fv/.github/skillsNotes
Validation
npm run build:components -w @ni/ok-componentsnpm run build:ts -w @ni-private/storybook