Repository navigation
0.22.3: the manifest read resolves S3 options from the environment - #175
Merged
Merged
Conversation
…nment 0.22.1 passed pyiceberg no properties when a reader gave no s3_options, so a non-AWS endpoint in the environment never reached it (ACCESS_DENIED). Found by agent-office's end-to-end office test on its 0.7.2 build. build: 0.22.3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PXyESUWnfYF3jXPHp7pz12
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.22.1's
_counted_from_manifestsgave pyiceberg{}when a reader passed nos3_options, instead ofS3Options().resolved()as litelink does, so an endpoint set only in the environment (AWS_ENDPOINT_URL) never reached it and the open asked AWS (ACCESS_DENIED). Caught by agent-office's end-to-end test on its 0.7.2 build (agents read with no explicit options there).New test: an S3 table opened with no options, the endpoint and key only in the environment, against rustfs: fails before with the e2e's exact error, passes after. published, reopen_credentials, snapshot_readers, catchup_pages with S3 required: 47 passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PXyESUWnfYF3jXPHp7pz12