Repository navigation
0.22.2: every reopen of a log is given the stream's s3_options - #173
Merged
Merged
Conversation
`litelink.new` got them and `litelink.open` did not, so a reopened log read its published table with whatever key the environment held. A server whose streams publish to different stores could not restart once a stream had published: ACCESS_DENIED on its own metadata.json. build: 0.22.2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PXyESUWnfYF3jXPHp7pz12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream.newpasseds3_optionstolitelink.new(create) but not tolitelink.open(reopen), nor did migrate/retire/retain/revive/the retired open; a reopened log resolved credentials from the environment. A server whose streams publish to different stores could not restart after a stream's first publish (ACCESS_DENIED on its own metadata.json): seen in production, an office's message broker down on every restart.Fix: every in-process
litelink.opengets the stream's options (_metadata.completetoo). Maintainers are unchanged (they get options via their environment).New
tests/test_reopen_credentials.pyreproduces it against rustfs with the environment holding another key or none: fails before the fix with the production error, passes after; mutation (drop the options from_open_or_createonly) fails both. WithSTREAMCAST_REQUIRE_S3=1: reopen_credentials, migrate, retention, restore, layout, process, published: 104 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01PXyESUWnfYF3jXPHp7pz12