Skip to content

chore: eslint cleanup - #5222

Open
timdeschryver wants to merge 2 commits into
mainfrom
eslint-cleanup
Open

chore: eslint cleanup#5222
timdeschryver wants to merge 2 commits into
mainfrom
eslint-cleanup

Conversation

@timdeschryver

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We didn't pay attention to eslint rules while migrating from tslint => eslint => eslint flat config.

What is the new behavior?

This PR cleans things up:

  • remove eslint disable comments that are no longer applicable
  • updates config to allow some patterms, e.g. no unused vars
  • addressing all remaining ESLint warnings
  • migrates the deprecated nx/eslint:lint executor

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 8c976e3
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6a9720b5f4f90f0008230bab
😎 Deploy Preview https://deploy-preview-5222--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rainerhahnekamp

Copy link
Copy Markdown
Contributor

@timdeschryver, why do we allow any?

@timdeschryver

Copy link
Copy Markdown
Member Author

@timdeschryver, why do we allow any?

@rainerhahnekamp primarily history and not giving it any focus, and IIRC to make the types simpler at some places.
We can definitely look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants