Skip to content

build: enable strict mode #5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timdeschryver wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: enable strict mode #5221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions modules/component-store/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,14 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/modules/component-store",
"paths": {
"@ngrx/operators": ["./dist/modules/operators"]
},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
"paths": {
"@ngrx/operators": ["../../dist/modules/operators"]
}
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/component-store"
}
Expand Down
24 changes: 2 additions & 22 deletions modules/component/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,11 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": ".",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"strictPropertyInitialization": true,
"strictNullChecks": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/packages/component",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
"useDefineForClassFields": false
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"strictMetadataEmit": true,
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/component"
Expand Down
22 changes: 2 additions & 20 deletions modules/data/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,11 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/modules/data",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
"useDefineForClassFields": false
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/data"
}
Expand Down
22 changes: 3 additions & 19 deletions modules/effects/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,14 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/modules/effects",
"useDefineForClassFields": false,
"paths": {
"@ngrx/operators": ["../../dist/modules/operators"]
},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
}
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/effects"
}
Expand Down
22 changes: 2 additions & 20 deletions modules/entity/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,11 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/modules/entity",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
"useDefineForClassFields": false
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/entity"
}
Expand Down
19 changes: 1 addition & 18 deletions modules/operators/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,16 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"ignoreDeprecations": "6.0",
"module": "preserve",
"moduleResolution": "bundler",
"outDir": "../../dist/modules/operators",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noImplicitOverride": true,
"noPropertyAccessFromIndexSignature": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true
},
"files": ["index.ts"],
"include": ["**/*.ts"],
"exclude": ["**/*.spec.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/operators"
}
Expand Down
22 changes: 2 additions & 20 deletions modules/router-store/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,11 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/modules/router-store",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
"useDefineForClassFields": false
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/router-store"
}
Expand Down
19 changes: 1 addition & 18 deletions modules/signals/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,16 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"ignoreDeprecations": "6.0",
"module": "preserve",
"moduleResolution": "bundler",
"outDir": "../../dist/modules/signals",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noImplicitOverride": true,
"noPropertyAccessFromIndexSignature": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true
},
"files": ["index.ts"],
"include": ["**/*.ts"],
"exclude": ["**/*.spec.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/signals"
}
Expand Down
22 changes: 2 additions & 20 deletions modules/store-devtools/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,11 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"module": "preserve",
"moduleResolution": "bundler",
"noEmitOnError": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"ignoreDeprecations": "6.0",
"outDir": "../../dist/modules/store-devtools",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true
"useDefineForClassFields": false
},
"files": ["public_api.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/store-devtools"
}
Expand Down
20 changes: 2 additions & 18 deletions modules/store/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,13 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
"baseUrl": "../../",
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"ignoreDeprecations": "6.0",
"module": "preserve",
"moduleResolution": "bundler",
"outDir": "../../dist/modules/store",
"paths": {},
"rootDir": ".",
"sourceMap": true,
"inlineSources": true,
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": false,
"skipLibCheck": true,
"strict": true
"useDefineForClassFields": false
},
"files": ["public_api.ts"],
"include": ["**/*.ts"],
"exclude": ["**/*.spec.ts"],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial",
"flatModuleOutFile": "index.js",
"flatModuleId": "@ngrx/store"
}
Expand Down
22 changes: 22 additions & 0 deletions tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"compilerOptions": {
"declaration": true,
"stripInternal": true,
"experimentalDecorators": true,
"ignoreDeprecations": "6.0",
"module": "preserve",
"moduleResolution": "bundler",
"lib": ["ES2022", "dom"],
"target": "ES2022",
"useDefineForClassFields": true,

@timdeschryver timdeschryver Aug 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to enable this in a feature release for all packages (currently only signals and operators).
useDefineForClassFields is the new standard (with ES2022).

But this will be some work #3654

"sourceMap": true,
"inlineSources": true,
"skipLibCheck": true,
"strict": true,
"noImplicitReturns": true
},
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
"compilationMode": "partial"
}
}