Skip to content

test: re-enable skipped tests #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timdeschryver wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −49
Open

test: re-enable skipped tests #5220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839e299
test(data): re-enable skipped tests
timdeschryver Aug 31, 2026
a2f0f8d
test(router-store): re-enable skipped tests
timdeschryver Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions modules/data/spec/entity-services/entity-collection-service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,9 @@ describe('EntityCollectionService', () => {
}));
});

describe.skip('saves (optimistic)', () => {
describe('saves (optimistic)', () => {
beforeEach(() => {
TestBed.configureTestingModule({
/* eslint-disable-next-line @typescript-eslint/no-use-before-define */
providers: [
{
provide: EntityDispatcherDefaultOptions,
Expand All @@ -289,10 +288,9 @@ describe('EntityCollectionService', () => {
combinedSaveTests(true);
});

describe.skip('saves (pessimistic)', () => {
describe('saves (pessimistic)', () => {
beforeEach(() => {
TestBed.configureTestingModule({
/* eslint-disable-next-line @typescript-eslint/no-use-before-define */
providers: [
{
provide: EntityDispatcherDefaultOptions,
Expand Down Expand Up @@ -517,7 +515,15 @@ function entityServicesSetup() {

TestBed.configureTestingModule({
imports: [
StoreModule.forRoot({}),
StoreModule.forRoot(
{},
{
runtimeChecks: {
// @ngrx/data sets the error on the action when a reducer throws
strictActionImmutability: false,
},
}
),
EffectsModule.forRoot([]),
EntityDataModule.forRoot({
entityMetadata: entityMetadata,
Expand Down
8 changes: 0 additions & 8 deletions modules/data/spec/reducers/entity-change-tracker-base.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,6 @@ describe('EntityChangeTrackerBase', () => {
});
});

describe.skip('#mergeSaveDeletes', () => {
// TODO: add some tests
});

describe.skip('#mergeSaveUpdates', () => {
// TODO: add some tests
});

describe('#mergeSaveUpserts', () => {
it('should use default overwrite changes strategy', () => {
let {
Expand Down
36 changes: 0 additions & 36 deletions modules/router-store/spec/integration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,42 +141,6 @@ describe('integration spec', () => {
});
}));

test.skip('should support preventing navigation', () =>

@timdeschryver timdeschryver Aug 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RxJS 6 this isn't support anymore because subscriber errors are reported asynchronously

new Promise<void>((done) => {
const reducer = (state = '', action: RouterAction<any>) => {
if (
action.type === ROUTER_NAVIGATION &&
action.payload.routerState.url.toString() === '/next'
) {
throw new Error('You shall not pass!');
} else {
return state;
}
};

createTestModule({ reducers: { reducer } });

const router = TestBed.inject(Router);
const log = logOfRouterAndActionsAndStore();

router
.navigateByUrl('/')
.then(() => {
log.splice(0);
return router.navigateByUrl('next');
})
.catch((e) => {
expect(e.message).toEqual('You shall not pass!');
expect(log).toEqual([
{ type: 'router', event: 'NavigationStart', url: '/next' },
{ type: 'router', event: 'RoutesRecognized', url: '/next' },
{ type: 'router', event: 'NavigationError', url: '/next' },
]);

done();
});
}));

it('should ignore routing actions for the URL that is currently open', async () => {
createTestModule({
reducers: { router: routerReducer },
Expand Down