build: remove deprecated baseUrl from tsconfig.json - #5203
robert-md-or wants to merge 1 commit into
Conversation
Verification Guide for ReviewersWhy use a third-party tool instead of a manual/scripted fix?
What the tool actually checked, and why the change is safe:
Since no project relied on Only the root rootDir: Ran Verification performed:
This is the third and final PR from the categories identified in #5163 that I'm addressing ( |
|
The I checked out Result: 118 test files, 890 tests, all passing, 0 type errors — including both Since this PR only removes |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The root
tsconfig.jsonsetsbaseUrl: ".", which TypeScript hasdeprecated starting in 6.0 as part of the same cleanup tracked in
#5163.
baseUrlwillstop functioning entirely in TypeScript 7.0.
What is the new behavior?
Removed
baseUrlfromtsconfig.json, using the official@andrewbranch/ts5to6migration tool (built by a TypeScript teammember specifically for this and the related
rootDirmigration):The tool analyzed all 45 tsconfig files in the workspace and confirmed
baseUrlwas only ever used as an implicit prefix for thepathsentries in the root config — not as a fallback module resolution root
— so removing it is a no-op change in behavior (
✓ No projects rely on baseUrl for module resolution). Only the roottsconfig.jsonsetbaseUrldirectly; the other 37 potentially-affected projectsinherited it via
extendswithout redefining it themselves, so noother files needed changes.
Also ran the tool's
rootDircheck as part of the same cleanupcategory:
This reported no changes needed — the
rootDirvalues alreadypresent match what TypeScript 5.9 would infer automatically, so
nothing to migrate there.
Verified with:
pnpm nx run store:build— clean buildpnpm nx run eslint-plugin:test— 78 test files, 554 tests, 0 typeerrors
This closes out the last remaining category from
#5163 that this
contributor is addressing (
downlevelIterationandmoduleResolutionwere covered in separate PRs). The one open item from that issue,
modules/store/spec/ngc/tsconfig.ngc.json(an apparently-unusedtarget: "ES5"config), is left for maintainers to decide on.Does this PR introduce a breaking change?
Other information
Related to #5163.