Add Simplicity Guardian CI check (#382)#393
Open
ngarbezza wants to merge 12 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ncy (#382) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…on (#382) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🛡️ Simplicity Guardian❌ Zero-dependency (9)
✅ No dark magic — OK❌ Fan-out (1)
✅ ESLint — OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/simplicity-guardian.js— script CLI puro (zero deps) que escanealib/ybin/con 3 capas: zero-dependency, dark-magic (Proxy/defineProperty/__proto__) y fan-out (>7 imports por archivo).github/workflows/simplicity_guardian.yml— workflow CI triggered enpull_request, corre el guardian + ESLint y postea un comentario en el PR con el detalle de cada violación.github/scripts/post-pr-comment.cjs— script que construye y upsertea el comentario markdown en el PR (actualiza si existe, crea si no, limpia cuando todo está ok)testy-libscope:class-methods-use-this,max-classes-per-file,no-else-return,no-restricted-syntax(Proxy/defineProperty),no-restricted-imports(layer direction: core → no depende de ui)staticacrosslib/, addseslint-disablewhere multi-class files are justified by design patternsTest Plan
npm run lint— 0 erroresnode bin/simplicity-guardian.js lib bin— produce salida de texto correcta en el repo actualnode bin/simplicity-guardian.js --format json lib bin— produce JSON válido conviolationsysummarymain(requiere merge y nuevo PR)🤖 Generated with Claude Code