Skip to content

Compatibility fixes and new api implementations (tline, deli) to make kroom8 run - #58

Merged
mupfdev merged 8 commits into
ngagesdk:mainfrom
cherepets:compat/kroom8
Sep 4, 2026
Merged

mupfdev merged 8 commits into
ngagesdk:mainfrom
cherepets:compat/kroom8

Conversation

@cherepets

@cherepets cherepets commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator
  • I confirm that I am the author of this code and release it to the open8 project under the MIT license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

Description

Basically what I did is I run this game from terminal, and checked where it failed in the output.

  • Loading didn't work because of literals in 0x.f, fixed in patch_cart_code(), not in interpreter.
  • all(nil) - just return 0
  • pal(nil, 2) - just use 0 as a default value
  • pico8_stat(38 || 39) - just return 0, it's mouse movement for dev mode (which is not (yet?) supported)
  • pal(nil) - unset color set by pal(nil, 2)
  • implemented tline() - it's basically how the walls are drawn, not sure which algo does original pico-8 use but looked decent
  • implemented deli(i) - delete by index i
  • also fix add(t, val, i) to act like insert instead of replace

Note: the game is still not actually playable, it just boots and renders the environment

Existing Issue(s)

tline - #4

@codacy-production

codacy-production Bot commented Aug 28, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 54 complexity · 0 duplication

Metric Results
Complexity 54
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mupfdev

mupfdev commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thanks, highly appreciated.

PS: I just sent you a collaborator invite. If you accept, you can directly push to the main repo.

@mupfdev
mupfdev merged commit b6eda7f into ngagesdk:main Sep 4, 2026
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants