chore: update modules - #100
Conversation
tabix is deprecated and the htslib module can handle uncompressed, compressed and indexed vcf files without the necessity of channel branching.
|
I am not sure what to put in the changelog. just a simple "updated modules and subworkflows" in the changed section? or the specific changes in the depedencies section? since modules often don't have versioning (right?) should I use the git hashes from modules.json? |
and if the version is increased from modules then add it to the dependencies For Example then we need to make sure that if these updated tools are used in local modules that there the version is also updated so we have the same version for one tool across the whole pipeline :) |
that is concerning the core tool version right? not the nf-core module "wrapper"? they are versioned by git hashes (in modules.json), right?
right, that sounds good. bcftools v1.22 is used in local modules intersect/vcf and reformat/vcf according to the conda env. so should we hold back on that update for now? |
Yes, I think we can omit the git hashes in the CHANGELOG. If someone wants to really investigate they can look at the changes from a PR in the modules.json. We only care about tool versioning in that regard!
If you want you can simply add the tool update for the local modules to this PR. Let me know if you need guidance on anything regarding that :) |
famosab
left a comment
There was a problem hiding this comment.
Nice work, i would just adapt the local modules to the new syntax (see proposed changes) and update the docs then we can merge this :)
Co-authored-by: Famke Bäuerle <45968370+famosab@users.noreply.github.com>
This PR updates several modules and subworkflows.
Modules:
Subworkflows:
closes #99
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).