fix grouping issues - #21
Merged
Merged
Conversation
ToonRosseel
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On resume, the pipeline tends to not recognize files from the same pool. This ends up with two MultiQC runs per pool and produces two different reports (one overwrites the other).
This PR makes sure the group is always of size 2 (sex check + crosscheck fingerprints) before running MultiQC. If this size is not reached, MultiQC will refuse to run from now on.
I also reinitialized the keys before grouping to make sure they are exactly the same. This should prevent the resume issue from happening again