Skip to content

chore(registry): SX-3 review follow-ups (scanner encodings, scan memory, deploy guide env flags) #61

Closed

Description

@mrgoonie

Follow-ups from the PR #59 round-2 review (non-blocking while SKILLX_RELEASES_API is off):

  • Scanner false positives (r2-m1): UTF-16 .ps1 scripts (with a BOM), legacy-codepage .bat/.cmd/.csv files, binaries under scripts/, and LICENSE.txt may be quarantined. Decode UTF-16 when it has a BOM, and tune the injection scan for license and plain-text files.
  • Scan memory (r2-m2): each file is built as a full string, plus a join and a decode. A 32 MiB tree can exceed the 128 MB isolate. Stream the scan per file, or cap the text size scanned.
  • Budget guard: move it before the scan and the signing.
  • Settings UI: label scoped keys.
  • Deployment guide: it uses --env production / --environment production throughout, but wrangler.jsonc declares no environments. The production worker is skillx-web, so drop those flags across the guide and the README.

Refs #54, #59

Activity

  1. self-assigned this
    on Oct 19, 2026
  2. added and removed on Oct 19, 2026
  3. added a commit that references this issue on Oct 20, 2026
    d54ea6c
  4. mrgoonie commented on Oct 20, 2026

    @mrgoonie
    ContributorAuthor

    Shipped: fixed by #96 (squash fbd0333, merged 2026-10-20 after 6 isolated review rounds). Deployed to production skillx-web (worker version 27d34bce at fbd0333; current 7d29ff0a at 79f98fb). Smoke 2026-10-20: /, /api/search and registry keys 200.

  5. added
    shippedMerged/deployed
    and removed on Oct 20, 2026
  6. added a commit that references this issue on Oct 20, 2026
    fbd0333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

shippedMerged/deployed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions