document hook: Allow owners to view their trashed documents. - #88
Merged
Conversation
Previously, opening a document in trash (from the trash panel) or having an open document trashed from another tab/device showed a spurious "Access to this document has been restricted" error with response code 404. Realtime connections were still established for trashed documents, but the realtime server strictly rejects access checks for them (1008 close), and the close handler then treated the owner's own trashed document as a revocation. This commit skips realtime connections for trashed documents, which are served as a read-only, REST-only trash view, and when an open document is moved to trash elsewhere, surfaces the read-only trash view instead of the restricted error. Regression tests cover both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, opening a document in trash (from the trash panel) or having an open document trashed from another tab/device showed a spurious "Access to this document has been restricted" error with response code 404.
Realtime connections were still established for trashed documents, but the realtime server strictly rejects access checks for them (1008 close), and the close handler then treated the owner's own trashed document as a revocation.
This commit skips realtime connections for trashed documents, which are served as a read-only, REST-only trash view, and when an open document is moved to trash elsewhere, surfaces the read-only trash view instead of the restricted error. Regression tests cover both cases.