fix(database): stop logging per page load and leaking two listeners

css/serverinfo-main.css

@@ -1,2 +1,2 @@
 /* extracted by css-entry-points-plugin */
-@import './main-BGnaytV2.chunk.css';
+@import './main-CTcIB92A.chunk.css';

lib/Database/Advisor.php

@@ -130,7 +130,12 @@ private function evaluateRule(Rule $rule, Snapshot $snapshot, array $context): R
 		try {
 			$value = $this->evaluator->evaluate($rule->formula, $context);
 		} catch (ExpressionException $e) {
-			$this->logger->warning(
+			// Debug, not warning: a variable that is not a number on this server is
+			// ordinary — MariaDB reports concurrent_insert as AUTO where MySQL
+			// reports an integer — and the rule says so in its skip reason. At
+			// warning level it would land in the log on every page load and inflate
+			// the "Errors in the log" setup check.
+			$this->logger->debug(
 				'serverinfo: failed to evaluate formula for rule {id}: {msg}',
 				['id' => $rule->id, 'msg' => $e->getMessage(), 'app' => 'serverinfo'],
 			);
@@ -153,7 +158,9 @@ private function evaluateRule(Rule $rule, Snapshot $snapshot, array $context): R
 			$failed = $this->evaluator->evaluate($rule->test, $testCtx);
 			$failed = is_bool($failed) ? $failed : ($valueFloat !== 0.0);
 		} catch (ExpressionException $e) {
-			$this->logger->warning(
+			// Debug for the same reason as the formula above: reported to the admin
+			// as a skipped rule, not something to write to the log every time.
+			$this->logger->debug(
 				'serverinfo: failed to evaluate test for rule {id}: {msg}',
 				['id' => $rule->id, 'msg' => $e->getMessage(), 'app' => 'serverinfo'],
 			);

src/components/DatabaseLiveCharts.vue

@@ -131,16 +131,25 @@ watch(() => [props.active, document.hidden], () => {
 	}
 }, { immediate: true })
 
-document.addEventListener('visibilitychange', () => {
+/**
+ * Pauses while the tab is in the background and resumes on return.
+ *
+ * Named rather than inline so that it can be taken off again: an anonymous
+ * handler here would outlive the component.
+ */
+function onVisibilityChange() {
 	if (document.hidden) {
 		stop()
 	} else if (props.active && timeoutId === null) {
 		poll()
 	}
-})
+}
+
+document.addEventListener('visibilitychange', onVisibilityChange)
 
 onUnmounted(() => {
 	stopped = true
+	document.removeEventListener('visibilitychange', onVisibilityChange)
 	stop()
 })
 

src/views/SettingsAdmin.vue

@@ -23,7 +23,7 @@
 <script setup lang="ts">
 import type { LiveData, PeriodicData, SettingsView } from '../types.ts'
 
-import { ref, watch } from 'vue'
+import { onUnmounted, ref, watch } from 'vue'
 import SettingsNavigation from '../components/SettingsNavigation.vue'
 import BackgroundJobsView from './BackgroundJobsView.vue'
 import DatabaseView from './DatabaseView.vue'
@@ -54,8 +54,18 @@ watch(view, (current) => {
 	window.history.replaceState(null, '', `#${current}`)
 })
 
-window.addEventListener('hashchange', () => {
+/**
+ * Keeps the page in step with the fragment when the browser changes it, for
+ * instance on back/forward. Named so it can be removed again.
+ */
+function onHashChange() {
 	view.value = viewFromHash()
+}
+
+window.addEventListener('hashchange', onHashChange)
+
+onUnmounted(() => {
+	window.removeEventListener('hashchange', onHashChange)
 })
 
 const { data: staticData } = useStaticData()