Repository navigation
fix: show when the page has stopped hearing from the server - #1122
Merged
Merged
Conversation
Member
Author
Both composables handled their errors and then threw the result away. useStaticData computed `loading` and `error`, but SettingsAdmin destructured only `data`, so both flags were dead code; useLiveData's catch block was empty by design. Every failure therefore looked the same from the outside, and none of them looked like a failure: - a failed /data request left the pulsing skeletons on screen forever, with no error, no explanation and no way to retry short of reloading - a server that had been unreachable for an hour was still polled every two seconds, with the charts showing their last values and nothing saying those values had stopped moving For a page whose whole job is to report the health of the server, quietly showing stale numbers or a loading animation is the worst of the available failure modes: it looks healthy. A failed /data request now says so and offers to try again. Once two polls in a row have failed -- one is usually a blip worth riding out -- a warning names the time the values were last current. The values themselves stay on screen, which is still the right call; what changes is that the page no longer implies they are live. Polling now also backs off while requests are failing, doubling up to a minute and returning to normal on the first success, so a server that is struggling is not asked for the same numbers thirty times a minute. Signed-off-by: Frank Karlitschek <frank.karlitschek@nextcloud.com> Assisted-by: Claude Code:claude-opus-5 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kesselb
force-pushed
the
fix/visible-failures
branch
from
September 9, 2026 18:02
e218595 to
d01e78d
Compare
kesselb
approved these changes
Sep 9, 2026
Collaborator
|
/backport to stable35 please |
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/1122/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d01e78d7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1122/stable35Error: Failed to check for changes with origin/stable35: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both composables handled their errors and then discarded the result.
useStaticDatacomputedloadinganderror, butSettingsAdmin.vuedestructured onlydata— so both flags were dead code.useLiveData'scatchblock was empty by design. Every failure therefore looked identical from the outside, and none of them looked like a failure:/datarequest left the pulsing skeletons on screen forever, with no error, no explanation, and no way to retry short of reloading the pageFor a page whose entire job is reporting the health of a server, quietly showing stale numbers or a loading animation is the worst of the available failure modes: it looks healthy. An admin checking whether their server is alright would be reassured by a page that had lost contact with it.
Change
/datarequest says so, and offers a Try again button that re-runs the request. The skeletons are no longer shown in that state, since nothing is loading.Verification
Driven against a live NC 35 instance with Playwright, failing the requests at the network layer:
/datafails from the start/updateand/periodicstart failing after a good loadScreenshots of both states are in the branch discussion below.
eslintclean;js/andcss/rebuilt and committed, and a second build is a no-op.Note on overlap
This touches
useLiveData.tsandSettingsAdmin.vue, so it will conflict textually with #1120 (which adds visibility gating to the same poller) and #1119 (which turnsSettingsAdmin.vueinto a shell). The changes are complementary rather than contradictory — I have them merged and running together on a test instance — so whichever lands first, I am happy to rebase the others onto it.