Repository navigation
fix(disk): stop the disk card text overflowing and tidy up the chart - #1068
Merged
Merged
Conversation
karlitschek
force-pushed
the
fix/disk-section-layout
branch
from
August 2, 2026 13:10
d8e3a50 to
b07716c
Compare
kesselb
force-pushed
the
fix/disk-section-layout
branch
from
August 2, 2026 21:37
b07716c to
ddd5fe8
Compare
kesselb
approved these changes
Aug 2, 2026
Let the text column shrink and break long device names, so a name like ubuntu--vg-ubuntu--lv no longer spills through the card border. Replace the viewport-based col-4 with an auto-fill grid that measures the settings pane the cards actually sit in. Turn the label/value pairs into a dl, so they no longer depend on whitespace that Vue condenses away, rendering "Available:25.76 GB". Tidy the chart: drop the white slice border that gashes the ring on dark themes, theme the arc colours, show the usage percentage in the hole, re-enable tooltips, and label the canvas for screen readers. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
fix/disk-section-layout
branch
from
August 2, 2026 21:41
ddd5fe8 to
35b39fd
Compare
kesselb
enabled auto-merge
August 2, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device name spilled out through the right border of the card. The text column was
flex: 1 0 auto, so it could never shrink below its max-content width, and a device name like ubuntu--vg-ubuntu--lv offers no break opportunity. Theword-breakthat would have caught it only lived inside thewidth <= 1280pxmedia query, so it was a wide-window-only bug.The cards also sized themselves off the viewport via
col-4, but the settings pane is much narrower than the window, so each card got a third of an already narrow column and every label wrapped. They are now an auto-fill grid that measures the container it actually sits in.Label/value pairs became a
dl. They previously relied on the whitespace between two adjacent spans, which Vue'swhitespace: 'condense'removes outright when it contains a newline, rendering "Available:25.76 GB". Core stylesdl/dt/ddfor prose (dt,dd{padding:12px},dt{width:130px}), which adds 24px to every row of a compact stat list, so that is reset here.While in the chart itself:
spacingbetween the arcs.馃 AI (if applicable)