Repository navigation
refactor(collaboration): rely on stable usort - #65969
Open
joshtrichards wants to merge 2 commits into
Open
joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
PHP 8 guarantees stable sorting, so remove the original-position tie-breaker used to preserve order for ties. Signed-off-by: Josh <josh.t.richards@gmail.com>
Remove the original-position tie-breaker workaround. PHP 8+ preserves the input order of equal elements, so sorting can operate directly on recipient arrays. Also add return typing. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
come-nc,
salmart-dev and
sorbaugh
and removed request for
a team
October 27, 2026 13:39
joshtrichards
added
feature: sharing
feature: comments
♻️ refactor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
🧹 Remove the original-position tie-breaker wrappers from
CommentersSorterandshareRecipientSorterwhich are no longer necessary today. Also add return typing in the latter.Tests: already covered.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)