Repository navigation
Conversation
…rable Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Mario Alfonso Pym Mejía <pymm@hitss.com>
MarioPym
requested review from
Altahrim,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
October 26, 2026 16:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requests sent by
OCA\Files_Sharing\External\Storageto remote servers, including theshareinforequest and the reachability checks (e.g. againststatus.phporocm-provider), rely on a hardcoded 10-second timeout. For large federated shares, the remote server may take longer to respond toshareinfo. The request then fails withcURL error 28and the share is reported as unavailable, with no way to adjust the limit (as reported in #29941).This change introduces the
sharing.federation.request_timeoutsystem configuration option (in seconds, defaulting to 10), which applies to bothtimeoutandconnect_timeoutfor these requests, and documents it inconfig.sample.php. The default value preserves the existing behavior. WebDAV requests for the same storage are unaffected and continue to usedavstorage.request_timeout.How to test
/index.php/apps/files_sharing/shareinfotakes more than 10 seconds to answer (e.g. a big share, or a remote that delays the response by 15 s).getShareInfo()fails after 10 s withcURL error 28: Operation timed out after 10000 milliseconds.occ config:system:set sharing.federation.request_timeout --type=integer --value=20and open it again.Unit test:
apps/files_sharing/tests/ExternalStorageTest.php.Checklist
3. to review, feature component)stable32)AI (if applicable)