Repository navigation
Fix frankenphp shutdown functions - #65563
Merged
Merged
Conversation
Only the container and app containers are dropped, the server object itself is kept. That will allow to keep global state in the Server object if needed, and later to keep or revive some services. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Make sure to reset exception and error handler, and register shutdown functions through Server instance. For TempManager, rely on destructor instead. This helps reducing the number of service references floating around. There’s still something keeping database connections alive unidentified yet. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Default is too low. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-frankenphp-shutdown-functions
branch
from
October 27, 2026 08:36
c5f007e to
dd34b4d
Compare
come-nc
marked this pull request as ready for review
October 27, 2026 09:09
come-nc
requested review from
Altahrim,
icewind1991,
provokateurin and
sorbaugh
and removed request for
a team
October 27, 2026 09:09
come-nc
added
3. to review
provokateurin
approved these changes
Oct 27, 2026
CarlSchwan
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt at fixing the service leak currently happening when using frankenphp worker mode.
At some point database connection pool is exhausted because services from previous requests are not garbage collected.
This removes one of the references that were kept against some services: shutdown functions.
It does not fix the issue yet, so there must be other sources of references to container or services outside of the request lifecycle.
This also keeps the Server object around and only rebuilds the internal containers.
Checklist
3. to review, feature component)stable32)AI (if applicable)