Repository navigation
refactor: map sharing instances to ints, and add instance to indices - #65512
Open
icewind1991 wants to merge 1 commit into
Open
icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
icewind1991
requested review from
Altahrim,
salmart-dev and
sorbaugh
and removed request for
a team
October 14, 2026 19:09
Member
Author
|
/backport to stable35 |
2 of 10 tasks
icewind1991
force-pushed
the
unified-sharing-indices
branch
4 times, most recently
from
October 14, 2026 19:51
3b624cf to
359f94c
Compare
provokateurin
requested changes
Oct 27, 2026
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-sharing-indices
branch
from
October 27, 2026 20:03
359f94c to
3c6ad2c
Compare
provokateurin
requested changes
Oct 28, 2026
| /** | ||
| * @return non-empty-string|null | ||
| */ | ||
| public function getInstanceUrl(mixed $id): ?string { |
Member
There was a problem hiding this comment.
Suggested change
| public function getInstanceUrl(mixed $id): ?string { | |
| public function getInstanceUrl(?int $id): ?string { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)