Conversation
Doctrine converts driver-level exceptions into typed DBAL exceptions for queries, but Connection::doCommit() leaves them untouched. A deadlock, or a Galera certification failure, raised at commit time therefore surfaced as a raw Doctrine\DBAL\Driver\PDO\PDOException. That class implements the driver exception interface, not Doctrine\DBAL\Exception, so ConnectionAdapter::commit() never wrapped it into a DbalException and the retry loop in Propagator::propagateChange() never saw it. The error reached the user as an HTTP 500, shown as "unknown error" in the web interface, when several uploads updated the same parent folder rows at once. Group folders hit this often because every member shares one storage. Run the driver exception through the platform exception converter so error 1213 becomes a DeadlockException and callers can detect it as retryable. Also guard both rollback calls in the propagator. A failed commit has already ended the transaction, so rolling back throws "there is no active transaction" and masks the original error. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctrine converts driver-level exceptions into typed DBAL exceptions for queries, but Connection::doCommit() leaves them untouched. A deadlock, or a Galera certification failure, raised at commit time therefore surfaced as a raw Doctrine\DBAL\Driver\PDO\PDOException. That class implements the driver exception interface, not Doctrine\DBAL\Exception, so ConnectionAdapter::commit() never wrapped it into a DbalException and the retry loop in Propagator::propagateChange() never saw it. The error reached the user as an HTTP 500, shown as "unknown error" in the web interface, when several uploads updated the same parent folder rows at once. Group folders hit this often because every member shares one storage.
Run the driver exception through the platform exception converter so error 1213 becomes a DeadlockException and callers can detect it as retryable.
Also guard both rollback calls in the propagator. A failed commit has already ended the transaction, so rolling back throws "there is no active transaction" and masks the original error.
Assisted-by: ClaudeCode:claude-opus-5
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)