Skip to content

fix: make file requests dialog accessible - #64471

Open
kristian-zendato wants to merge 5 commits into
masterfrom
fix/create-file-request-ui-a11y
Open

kristian-zendato wants to merge 5 commits into
masterfrom
fix/create-file-request-ui-a11y

Conversation

@kristian-zendato

Copy link
Copy Markdown
Contributor

Summary

Improve a11y of the Create file request dialog:

  1. Recipient emails are a semantic list — chips render in a <ul> / <li> with an accessible name (Recipient emails).
  2. Unambiguous chip delete labels — each close button is Remove email: {email} instead of a shared Remove email.
  3. Form labels are programmatically linked — visible legends use <label for>, fields have stable ids, helper text is aria-describedby, and the expiration date keeps a visible linked label.
  4. Upload destination is keyboard-operable — Enter/Space opens the folder picker; typing/paste still do not edit the path.
  5. Focus returns to New — after File request created closes, focus goes back to the New button instead of the Files keyboard-shortcuts UI.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
@kristian-zendato
kristian-zendato requested a review from a team as a code owner September 17, 2026 08:12
@kristian-zendato
kristian-zendato requested review from skjnldsv, sorbaugh and susnux and removed request for a team September 17, 2026 08:12
@susnux susnux changed the title Fix/create file request UI a11y fix: make file requests dialog accessible Sep 17, 2026
@susnux susnux added this to the Nextcloud 36 milestone Sep 17, 2026

<div v-if="password !== null" class="file-request-dialog__password-field">
<NcPasswordField
id="file-request-dialog-password"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the ID?

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
…equest UI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants