Skip to content

[stable33] fix: scope group share child permission updates to usergroup #64418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Sep 16, 2026
Merged

[stable33] fix: scope group share child permission updates to usergroup #64418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/integration/sharing_features/sharing-v1-part3.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,6 @@ Feature: sharing
| id | A_NUMBER |
| item_source | A_NUMBER |
| share_type | 3 |
| permissions | 23 |
| permissions | 31 |
| file_target | /subfolder |
| expireDate | |
4 changes: 3 additions & 1 deletion lib/private/Share20/DefaultShareProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,13 @@ public function update(\OCP\Share\IShare $share) {
->executeStatement();

/*
* Now update the permissions for all children that have not set it to 0
* Now update the permissions for all user-group children that have not set it to 0.
* Link shares also use parent for display (Manager::setLinkParent) and must be excluded.
*/
$qb = $this->dbConn->getQueryBuilder();
$qb->update('share')
->where($qb->expr()->eq('parent', $qb->createNamedParameter($share->getId())))
->andWhere($qb->expr()->eq('share_type', $qb->createNamedParameter(IShare::TYPE_USERGROUP)))
->andWhere($qb->expr()->neq('permissions', $qb->createNamedParameter(0)))
->set('permissions', $qb->createNamedParameter($share->getPermissions()))
->set('attributes', $qb->createNamedParameter($shareAttributes))
Expand Down
Loading